-
Notifications
You must be signed in to change notification settings - Fork 237
[Fix]: Stream map error #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I see why it doesn't get into the grpcweb trailers. When an exception is thrown, then If this branch gets merged in, I will adjust the grpcweb trailers branch to work with these changes, and then we should be OK |
Cool
Your PR regarding the trailers has already been approved and will be added to the master as soon as I can find the best way to merge them. I'll probably try merging your first one and incorporating the changes into the other PR for the adapter, but I'm still working on it. |
|
@aseigo Thank you for your patience and continued contribution. |
This PR corrects a pattern matching issue in the send_response function and adds integration tests for the map_error function. There was a suspicion that this function was not correctly sending errors in the trailers, so I decided to add new tests to specifically validate this.
@aseigo I've brought the changes to the master branch in this PR, and I see that everything works. I haven't been able to reproduce your
map_errorerror aside from the pattern matching issue. The tests are going according to what the Elixir customer expects.Is there another way I can reproduce the problem?