Skip to content

fix: upgrade openai and vercel ai packages to fix o1 errors#3146

Merged
lalalune merged 1 commit into
developfrom
fix/openai-o1-fix
Feb 2, 2025
Merged

fix: upgrade openai and vercel ai packages to fix o1 errors#3146
lalalune merged 1 commit into
developfrom
fix/openai-o1-fix

Conversation

@HashWarlock
Copy link
Copy Markdown
Contributor

@HashWarlock HashWarlock commented Feb 1, 2025

Relates to

OpenAI requests for o1 was not succeeding due to max_tokens being deprecated in favor of max_completion_tokens
from the API parameter list. This upgrades the SDKs to fix this issue.

API: https://platform.openai.com/docs/api-reference/chat/object

Risks

Low

Background

Fix with screenshots
image
image

What does this PR do?

What kind of change is this?

Bug fix

Documentation changes needed?

Testing

To reproduce, run the existing develop branch and use OpenAI and choose the model o1-preview

When you make a call to the agent, there will be an error thrown that says max_tokens is not supported for the model and to use max_completion_tokens instead.

Where should a reviewer start?

Detailed testing steps

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 1, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mcp97
Copy link
Copy Markdown
Contributor

mcp97 commented Feb 1, 2025

Have we tested that this doesn't introduce regressions for non-o1 models

mcp97
mcp97 approved these changes Feb 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcp97 mcp97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of comment :)

@HashWarlock
Copy link
Copy Markdown
Contributor Author

HashWarlock commented Feb 2, 2025

Have we tested that this doesn't introduce regressions for non-o1 models

Works with default models

@lalalune lalalune merged commit 907def2 into develop Feb 2, 2025
@lalalune lalalune deleted the fix/openai-o1-fix branch February 2, 2025 04:00
@odilitime odilitime mentioned this pull request Feb 6, 2025
Merged
lalalune added a commit that referenced this pull request May 3, 2026
@lalalune
Merge pull request #3146 from elizaOS/fix/openai-o1-fix
2e7e717 
fix: upgrade openai and vercel ai packages to fix o1 errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalalune lalalune lalalune approved these changes

+2 more reviewers

@mcp97 mcp97 mcp97 approved these changes

@Dashamala91 Dashamala91 Dashamala91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HashWarlock @mcp97 @lalalune @Dashamala91