Add classList to Svg.Attributes#24
Open
globaljake wants to merge 1 commit into
Open
Conversation
|
Would love to see this merged. The issue lives now here #17 |
|
What is the problem of using |
|
It's the Elm type system - |
They both are aliases for |
|
If I remember correctly, there was an issue during run-time then. |
Ah, I believe you are right here, in Html it sets propery className, which won't work on svg element, should use setAttribute. |
|
Arriving here via web-search, I agree that a similar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to https://github.com/elm-lang/svg/issues/17