-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add a basic telemetry service #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c62e286 to
66dc899
Compare
ereslibre
approved these changes
Aug 13, 2025
Collaborator
ereslibre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
packages/telemetry/src/index.ts
Outdated
Comment on lines
69
to
77
| try { | ||
| userId = readFileSync(USER_CONFIG_PATH, 'utf-8').trim(); | ||
| } catch (error) { | ||
| userId = uuidv4(); | ||
| this.writeUserId(CONFIG_DIR, USER_CONFIG_PATH, userId); | ||
| } | ||
| } else { | ||
| userId = uuidv4(); | ||
| this.writeUserId(CONFIG_DIR, USER_CONFIG_PATH, userId); |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having CONFIG_DIR and USER_CONFIG_PATH seems a bit off when reading the first time, having these two parameters instead of one
Co-Authored-By: Rover <noreply@endor.dev>
db13544 to
6fce2d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new telemetry service collects anonymous data to understand how developers use rover. It mostly uses counters just to understand the number of completed tasks and called commands.
Closes #37
Changes