-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add stop command to stop running tasks and clean up resources #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
575497a to
94bcd33
Compare
Angelmmiguel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments here.
|
@Angelmmiguel By default,
|
6b0ed98 to
ce572b3
Compare
|
Sorry, had to force push because I had to rebase to include |
Angelmmiguel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
stop command that stops the current running container and cleans up
Add a new
stopcommand that allows users to gracefully stop running tasks and clean up associated resources including Docker containers, Git worktrees, and branches.The command provides granular control over what resources to clean up through options, making it flexible for different use cases while providing a sensible default behavior.
Changes
rover stop <taskId>command with comprehensive cleanup options--remove-all,--remove-container, and--remove-git-worktree-and-branchflags--jsonoption for programmatic usageNotes
The stop command integrates with the existing task lifecycle by updating the task status to "cancelled" and providing users with helpful next steps like viewing logs, restarting, or completely deleting the task.
Closes: #78