chore: do not throw when commands have exit code other than 0 #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f2c05f to
870f65f
Compare
When we check the exit code of commands, do not throw if they have an exit code other than 0 (default execa behavior), otherwise our check will never be performed since we will raise to the next stack call.
870f65f to
62aa87d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve git command error handling across the codebase by adding the
reject: falseoption to prevent throwing errors and remove duplicate console output from task validation.This change makes git operations more resilient by handling errors gracefully instead of throwing exceptions, and eliminates redundant error messages shown to users.
Changes
reject: falseoption to alllaunchSyncgit commands inpackages/common/src/git.tsto prevent throwing on non-zero exit codespackages/cli/src/commands/task.tsisGitRepo(),getRepositoryRoot(),hasCommits(),branchExists(), andcreateWorktree()Notes
The
reject: falseoption allows git commands to return exit codes without throwing exceptions, enabling proper error handling through exit code checking rather than try/catch blocks. This approach provides better control over error scenarios and reduces unexpected crashes.Closes #151