-
Notifications
You must be signed in to change notification settings - Fork 15
chore: use docker user mapping as opposed to chown #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9d9ed1 to
c20eed8
Compare
c20eed8 to
1568590
Compare
53192f0 to
04ac240
Compare
Contributor
|
@ereslibre I updated the PR description as it mixed changes from other features (MCP) |
Angelmmiguel
reviewed
Oct 2, 2025
Contributor
Angelmmiguel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a few comments! Getting this right is quite tricky 😅
Angelmmiguel
approved these changes
Oct 2, 2025
Contributor
Angelmmiguel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Docker user mapping to avoid permission issues. This change improves the development experience by eliminating the need for file ownership changes.
Changes
--userflag to run containers with host user ID/GIDNotes
The Docker user mapping eliminates the common issue where files created inside containers are owned by root, requiring manual
chownoperations.