Skip to content

Conversation

@ereslibre
Copy link
Collaborator

@ereslibre ereslibre commented Sep 29, 2025

Implement Docker user mapping to avoid permission issues. This change improves the development experience by eliminating the need for file ownership changes.

Changes

  • Added Docker user mapping support using --user flag to run containers with host user ID/GID
  • Implemented proper subprocess handling to avoid exit on interruption
  • Generalized Dockerfile build args for better containerization
  • Enhanced init process with proper Ctrl-C handling for attribution questions

Notes

The Docker user mapping eliminates the common issue where files created inside containers are owned by root, requiring manual chown operations.

@ereslibre ereslibre changed the title chore: user docker user mapping as opposed to chown chore: use docker user mapping as opposed to chown Sep 29, 2025
@ereslibre ereslibre force-pushed the ereslibre/docker-user-mapping branch from e9d9ed1 to c20eed8 Compare September 29, 2025 09:47
@ereslibre ereslibre force-pushed the ereslibre/docker-user-mapping branch from c20eed8 to 1568590 Compare September 29, 2025 09:49
@ereslibre ereslibre force-pushed the ereslibre/docker-user-mapping branch from 53192f0 to 04ac240 Compare October 1, 2025 08:27
@ereslibre ereslibre marked this pull request as ready for review October 1, 2025 19:44
@ereslibre ereslibre requested a review from Angelmmiguel October 1, 2025 19:45
@Angelmmiguel
Copy link
Contributor

@ereslibre I updated the PR description as it mixed changes from other features (MCP)

Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a few comments! Getting this right is quite tricky 😅

Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ereslibre ereslibre merged commit 83b0fa5 into main Oct 2, 2025
4 checks passed
@ereslibre ereslibre deleted the ereslibre/docker-user-mapping branch October 2, 2025 10:13
@ereslibre ereslibre self-assigned this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants