chore: fix telemetry reporting #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7bb7b21 to
3b94974
Compare
3b94974 to
8ae9cee
Compare
Angelmmiguel
approved these changes
Nov 13, 2025
Contributor
Angelmmiguel
left a comment
There was a problem hiding this comment.
LGTM! Just added a minor comment 😄
| import { homedir } from 'os'; | ||
| import { join } from 'path'; | ||
| import { v4 as uuidv4 } from 'uuid'; | ||
| import devConfig, { prodConfig } from './config.js'; |
Contributor
There was a problem hiding this comment.
I would delete this entire file since it's no longer required.
Comment on lines
+29
to
+31
| define: { | ||
| __BUILD_CONFIG__: JSON.stringify(selectedConfig), | ||
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #289
Fixes an issue where telemetry was not being properly shut down when commands exit with errors, warnings, or success messages. This could lead to incomplete telemetry data or hanging processes.
Changes
exitWithError,exitWithSuccess, andexitWithWarnutility functions to accept telemetry instance and shut it down before exitingbuild-devnpm scripts to root and CLI packages for faster development builds without minificationdelete,logs,merge,push, anditeratecommands to pass telemetry instanceNotes
The telemetry shutdown is now consistently handled across all exit paths, ensuring proper cleanup regardless of command success or failure. The development build scripts improve the developer experience by reducing build times during development iterations.