Skip to content

Conversation

@Angelmmiguel
Copy link
Contributor

@Angelmmiguel Angelmmiguel commented Aug 8, 2025

Update the package manager in the extension folder to use npm. By default, the @vscode/vsce (extension packager) tool does not support pnpm, causing a required dependency upgrade when building the extension.

This is not strictly related to #32, but might cause potential inconsistencies. For that reason, I included this PR as part of this issue.

Update

After checking it with @ereslibre, I took the opportunity to update the project to use npm. I configured the workspace and move all the current projects (cli and extension) to the packages folder.

Each project uses now their own package.json and share a workspace to simplify dependency management and configuration.

@Angelmmiguel Angelmmiguel requested a review from ereslibre August 8, 2025 09:47
@Angelmmiguel Angelmmiguel self-assigned this Aug 8, 2025
@Angelmmiguel Angelmmiguel added this to the beta milestone Aug 8, 2025
@Angelmmiguel
Copy link
Contributor Author

The changes I implement related to codicons and the .vscodeignore are related to an issue with the vsce packaging and npm behavior.

Currently, npm resolves all dependencies in the project root node_modules folder, while the extension required to include the codicons files in the package. For that reason, I copied them manually using a custom esbuild plugin.

I had to add the ../ and ../../ paths to the .vscodeignore file because the vsce tool was adding all the files in the repo (including node_modules) to the extension package. I found the solution on https://stackoverflow.com/a/74909348.

@Angelmmiguel Angelmmiguel changed the title fix: use npm as the package manager for the extension as pnpm is not supported feat: update project to use npm workspaces Aug 8, 2025
@Angelmmiguel Angelmmiguel merged commit 34f1c45 into main Aug 8, 2025
3 checks passed
@Angelmmiguel Angelmmiguel deleted the 32/ubuntu-issue branch September 11, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants