Isolate use of HideableValue in Enso code #14039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HideableValue only used in Enso_Secret.enso. Only called by Enso just before going to Java.
AdRiley
approved these changes
Sep 22, 2025
GregoryTravis
approved these changes
Sep 22, 2025
2 tasks
Member
There was a problem hiding this comment.
- encapsulating all usage of
HideableValuein a singleEnso_Secretmodule is a laudable goal - but
as_hideable_valuereturns theHiddenValueJava class ... - ...and there is still ~twenty usages of that method in
distribution - I am afraid the goal hasn't been achieved yet
| import Standard.Base.Errors.Illegal_Argument.Illegal_Argument | ||
| import Standard.Base.Metadata.Display | ||
| from Standard.Base.Enso_Cloud.Enso_Secret import as_credential_reference, as_hideable_value | ||
| from Standard.Base.Enso_Cloud.Enso_Secret import as_credential_reference |
Member
There was a problem hiding this comment.
- Can
as_hideable_valuebe markedprivate? - That would fulfil the HideableValue only used in Enso_Secret.enso goal in the description of this PR
- However when I do
grep -r as_hideable_value distributionI still see a lot of usages ofHideableValueoutside ofEnso_Secret
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Derived_Secret_Value(was used by Snowflake).HideableValueonly used in Enso_Secret.enso.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.