Skip to content

feat: serde::redact_secret convenience serialize_with - serialize without exposing#46

Merged
eopb merged 3 commits into
mainfrom
serde-redacted
Jan 25, 2024
Merged

feat: serde::redact_secret convenience serialize_with - serialize without exposing#46
eopb merged 3 commits into
mainfrom
serde-redacted

Conversation

@eopb

@eopb eopb commented Nov 5, 2023

Copy link
Copy Markdown
Owner

resolves #45

Todo

  • Document function with rustdoc
  • Update serde section in README.md

…out exposing

# Todo
- [ ] Document function with rustdoc
- [ ] Update serde section in `README.md`
@8de2fdb0

8de2fdb0 commented Nov 6, 2023

Copy link
Copy Markdown

Maybe call it redact_secret, that would be more in line with the existing expose_secret function.

And thanks for adding that.

@eopb

eopb commented Nov 8, 2023

Copy link
Copy Markdown
Owner Author

Maybe call it redact_secret, that would be more in line with the existing expose_secret function.

And thanks for adding that.

Good idea. I prefer that

@8de2fdb0

8de2fdb0 commented Dec 2, 2023

Copy link
Copy Markdown

still thinking about it ?

@eopb

eopb commented Dec 5, 2023

Copy link
Copy Markdown
Owner Author

still thinking about it ?

Hey, yes. I've just put this on the back burner since life's been hectic.

I still need to update the name and add some documentation. I'll probably get to it in the coming weeks. If you'd like, please feel free to pick it up and open a PR.

@eopb eopb marked this pull request as ready for review January 25, 2024 21:23
@eopb eopb merged commit c576645 into main Jan 25, 2024
@eopb eopb deleted the serde-redacted branch January 25, 2024 21:24
@github-actions github-actions Bot mentioned this pull request Jan 25, 2024
@eopb eopb changed the title feat: serde::redacted convenience serialize_with - serialize without exposing feat: serde::redact_secret convenience serialize_with - serialize without exposing Jan 25, 2024
eopb added a commit that referenced this pull request Mar 23, 2024
This was introduced in #46 and is required for #50
eopb added a commit that referenced this pull request May 11, 2024
This type was unintentionally made public in #46

Since that was a few releases ago, I think it'd be probably best to keep it public.i

`redact` attempts to be stable, I don't want to risk breaking any code.
eopb added a commit that referenced this pull request May 11, 2024
This type was unintentionally made public in #46

Since that was a few releases ago, I think it'd be probably best to keep it public.i

`redact` attempts to be stable, I don't want to risk breaking any code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add convenience serialize_with function to Serialize data without exposing it

2 participants