Fixes for ImDrawList::AddRect() signature change in 19276.#703
Conversation
|
To clarify this is required to safely build with When Evan was away I used to merge/push occasionally hot-fixes directly myself. (only asking for hot-fix relative to catching with imgui core changes) |
|
Thanks for implementing the fix @ocornut!
I would prefer for you to continue opening PRs so I get notified of the changes. This way I can also make sure I implement the necessary changes in ImPlot3D. |
|
Regardless I would open PR for visibility but I could potentially merge the hot fix for ImPlot and you still get notified. I’ll try to add ImPlot3d to my test bed so it’s better tested on my end too. Thanks for merging! |
|
Fix for breaking change ocornut/imgui@6df50a0#diff-cbc47f9fc55eb2c19b4be92d1c1e137bb8b72d072588ab3cb4bcba88576d14cb
ImPlot3D would need a similar fix is using the last two parameters of
ImDrawList::AddRect().