Skip to content

Fixes for ImDrawList::AddRect() signature change in 19276.#703

Merged
brenocq merged 1 commit into
epezent:masterfrom
ocornut:fix_addrect_1928
May 10, 2026
Merged

Fixes for ImDrawList::AddRect() signature change in 19276.#703
brenocq merged 1 commit into
epezent:masterfrom
ocornut:fix_addrect_1928

Conversation

@ocornut
Copy link
Copy Markdown
Collaborator

@ocornut ocornut commented May 7, 2026

Fix for breaking change ocornut/imgui@6df50a0#diff-cbc47f9fc55eb2c19b4be92d1c1e137bb8b72d072588ab3cb4bcba88576d14cb

ImPlot3D would need a similar fix is using the last two parameters of ImDrawList::AddRect().

@ocornut
Copy link
Copy Markdown
Collaborator Author

ocornut commented May 7, 2026

To clarify this is required to safely build with #define IMGUI_DISABLE_OBSOLETE_FUNCTIONS.

When Evan was away I used to merge/push occasionally hot-fixes directly myself.
@brenocq Would you like me to keep doing so or would you prefer that I let know merge the PR yourself?

(only asking for hot-fix relative to catching with imgui core changes)

@ocornut ocornut force-pushed the fix_addrect_1928 branch from 20ea358 to 1b4e586 Compare May 7, 2026 15:11
@ocornut ocornut force-pushed the fix_addrect_1928 branch from 1b4e586 to ca87623 Compare May 7, 2026 15:12
@brenocq
Copy link
Copy Markdown
Collaborator

brenocq commented May 10, 2026

Thanks for implementing the fix @ocornut!

@brenocq Would you like me to keep doing so or would you prefer that I let know merge the PR yourself?

I would prefer for you to continue opening PRs so I get notified of the changes. This way I can also make sure I implement the necessary changes in ImPlot3D.

@brenocq brenocq added type:fix Something isn't working prio:high High priority status:done Task completed successfully labels May 10, 2026
@brenocq brenocq merged commit 9751e23 into epezent:master May 10, 2026
18 checks passed
@ocornut
Copy link
Copy Markdown
Collaborator Author

ocornut commented May 10, 2026

Regardless I would open PR for visibility but I could potentially merge the hot fix for ImPlot and you still get notified. I’ll try to add ImPlot3d to my test bed so it’s better tested on my end too. Thanks for merging!

@neondev9
Copy link
Copy Markdown

I’ll try to add ImPlot3d to my test bed so it’s better tested on my end too.

@ocornut fyi: #694 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prio:high High priority status:done Task completed successfully type:fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants