Skip to content

feat: add terraform provider as submodule and configure upstream script#24

Merged
ocobles merged 9 commits into
mainfrom
terraform_upstream
Nov 6, 2023
Merged

feat: add terraform provider as submodule and configure upstream script#24
ocobles merged 9 commits into
mainfrom
terraform_upstream

Conversation

@ocobles

@ocobles ocobles commented Oct 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Configure upstream
  • Upgrade dependencies:
  1. golangci-lint v1.55.2
  2. gradle-version 7.6
  3. pulumi java generator v0.9.8
  4. pulumi sdk v3.91.1
  5. terraform provider v1.18.2
  • Patch upstream to add a Pulumi user-agent (I have added this patch as a test to prove that it works correctly, but I will open some issues for other necessary patches, for example to eliminate references to terraform documentation)
  • I have added gh actions to upgrade pulumi-terraform-bridge and provider, but it will require configuring a bot to be able to do it automatically

Added terraform submodule
694d2d2 
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
@ocobles ocobles changed the title add terraform provider as submodule and configure upstream script feat: add terraform provider as submodule and configure upstream script Oct 25, 2023
@github-actions

github-actions Bot commented Oct 25, 2023 •
edited
Loading

Copy link
Copy Markdown

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 1 breaking change:

Types

  • 🟢 "equinix:metal/getDevicesDevice:getDevicesDevice": required: "sosHostname" property has changed to Required
    No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@displague

displague commented Oct 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Is this necessary? I imagine this may only be necessary for providers that have their Provider definition locked away behind internal/.

In the Equinix TF Provider we intend to keep the Provider definition in the public equinix/ directory, as we move the resource definitions themselves to internal/.

https://github.com/equinix/terraform-provider-equinix/blob/main/equinix/provider.go#L47

@ocobles

ocobles commented Oct 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@displague we could really go ahead without this, but the main intention is to have the ability to patch the upstream terraform provider https://github.com/pulumi/pulumi-linode/blob/45f0351a1026bc7d44234f365f0308e7884da343/scripts/upstream.sh#L96

For example to replace references to terraform registry that doesn't make sense in Pulumi documentation

ocobleseqx added 2 commits October 26, 2023 19:15
configure upstream script and upgrade plugin workflows
7b74315 
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
fixup! configure upstream script and upgrade plugin workflows
4d31c51 
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
@ocobles ocobles marked this pull request as ready for review October 26, 2023 17:19
ocobleseqx added 6 commits October 26, 2023 19:24
fixup! configure upstream script and upgrade plugin workflows
6eb2267 
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
upgrade java gen, pulumi sdk, tf upstream, add patch for user agent
d9dfd66 
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
upgrade golangci-lint
4df8307 
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
update examples go dependencies
ee801b3 
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
go clean cache
f0c0c0f 
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
fix: add missing upstream sync step in gh actions
ee8a3f8 
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
ctreatma
ctreatma approved these changes Nov 3, 2023
View reviewed changes

@ctreatma ctreatma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trusting CI a bunch here; the combination of a bunch of different upgrades makes it hard to tease out what caused the various code changes. If we can, it would be nice to upgrade fewer things per PR in the future.

@ocobles ocobles merged commit 345d05a into main Nov 6, 2023
@ocobles ocobles mentioned this pull request Nov 6, 2023
Closed
@ctreatma ctreatma deleted the terraform_upstream branch August 21, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctreatma ctreatma ctreatma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ocobles @displague @ctreatma