Fix upstream to tag#32
Merged
Merged
Conversation
added 2 commits
November 6, 2023 16:53
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
Signed-off-by: ocobleseqx <oscar.cobles@eu.equinix.com>
Does the PR have any schema changes?Does the PR have any schema changes?Found 2 breaking changes: Resources
Maintainer note: consult the runbook for dealing with any breaking changes. |
|
Just wondering what would be the way to verify if the SHA is right for the upstream-provider |
Contributor
Author
|
@aayushrangwala I found it was failing by running https://github.com/pulumi/upgrade-provider locally. That's the tool the https://github.com/equinix/pulumi-equinix/blob/main/.github/workflows/upgrade-provider.yml action will use once it is configured. E2E test was failing here https://github.com/equinix/pulumi-equinix/actions/runs/6773373904/job/18408078544#step:9:57 after updating the upstream you can see here that test are green again |
|
/approve |
|
/lgtm |
displague
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream submodule was initially added using the last commit, but the upgrade-provider pulumi tool needs the SHA of a tag. I have manually checkout upstream to v1.19.0 and updated the go dependencies to that version as well
closed #31 in favor of this PR