[pull] master from gitbutlerapp:master #1513
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: 'Test' | |
| on: | |
| push: | |
| branches: | |
| - master | |
| pull_request: | |
| env: | |
| RUST_BACKTRACE: full | |
| RUSTUP_TOOLCHAIN: stable | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref }} | |
| cancel-in-progress: true | |
| jobs: | |
| changes: | |
| runs-on: ubuntu-latest | |
| outputs: | |
| node: ${{ steps.filter.outputs.node }} | |
| rust: ${{ steps.filter.outputs.rust }} | |
| ui: ${{ steps.filter.outputs.ui }} | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - uses: dorny/paths-filter@v3 | |
| id: filter | |
| with: | |
| filters: | | |
| workflows: &workflows | |
| - '.github/workflows/**' | |
| - '.github/actions/**' | |
| docs: | |
| - '**/*.md' | |
| node: | |
| - *workflows | |
| - 'apps/**' | |
| - 'packages/**' | |
| - 'package.json' | |
| - 'pnpm-lock.yaml' | |
| ui: | |
| - 'packages/ui/**' | |
| common-rust: &rust | |
| - *workflows | |
| - 'Cargo.lock' | |
| - 'Cargo.toml' | |
| rust: &any-rust | |
| - *rust | |
| - 'crates/**' | |
| prettier: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.node == 'false' && needs.changes.outputs.docs == 'true'}} | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - uses: ./.github/actions/init-env-node | |
| - run: pnpm prettier | |
| generate-ts-definitions: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.node == 'true' || needs.changes.outputs.rust == 'true' }} | |
| runs-on: ubuntu-latest | |
| env: | |
| CARGO_TERM_COLOR: always | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - name: Rust Cache | |
| uses: Swatinem/rust-cache@v2.8.2 | |
| with: | |
| shared-key: ts-def-gen | |
| save-if: ${{ github.ref == 'refs/heads/master' }} | |
| # Node is needed for the formatting of typescript files. | |
| - uses: ./.github/actions/init-env-node | |
| - name: Dependencies for 'keyring' | |
| run: sudo ./scripts/install-minimal-debian-dependencies.sh | |
| - run: ./scripts/generate-ts-definitions-from-rust.sh | |
| lint-node: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.node == 'true' }} | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - uses: ./.github/actions/init-env-node | |
| - run: pnpm lint | |
| check-node: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.node == 'true' }} | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - uses: ./.github/actions/init-env-node | |
| - run: pnpm check | |
| unittest-node: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.node == 'true' }} | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - uses: ./.github/actions/init-env-node | |
| - run: pnpm test | |
| rust-lint: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.rust == 'true' }} | |
| runs-on: ubuntu-latest | |
| container: | |
| image: ghcr.io/gitbutlerapp/ci-base-image:latest | |
| env: | |
| CARGO_TERM_COLOR: always | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - name: Rust Cache | |
| uses: Swatinem/rust-cache@v2.8.2 | |
| with: | |
| shared-key: lint | |
| save-if: ${{ github.ref == 'refs/heads/master' }} | |
| - run: cargo fmt --check --all | |
| - run: cargo check --workspace --all-targets | |
| - run: | | |
| # should work without the "legacy" feature | |
| cargo check -p but-testsupport --all-targets | |
| cargo check -p but-testsupport --all-targets --features sandbox | |
| cargo check -p but-testsupport --all-targets --features sandbox-but-api | |
| cargo check -p but-ctx --all-targets | |
| cargo check -p but-serde --all-targets | |
| cargo check -p but-meta --all-targets | |
| cargo check -p but-graph --all-targets | |
| cargo check -p but-workspace --all-targets | |
| cargo check -p but-github --all-targets | |
| cargo check -p but-api --all-targets | |
| cargo check -p but --no-default-features | |
| name: Special `cargo check` runs | |
| env: | |
| RUSTFLAGS: '--deny warnings' | |
| - name: cargo clippy | |
| run: | | |
| rustup component add clippy | |
| cargo clippy --workspace --all-targets -- -D warnings | |
| cargo-deny: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.rust == 'true' }} | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - uses: EmbarkStudios/cargo-deny-action@76cd80eb775d7bbbd2d80292136d74d39e1b4918 # v2.0.14 | |
| with: | |
| command: check bans licenses sources | |
| cargo-doc: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.rust == 'true' }} | |
| runs-on: ubuntu-latest | |
| env: | |
| CARGO_TERM_COLOR: always | |
| RUSTDOCFLAGS: -D warnings | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - name: Rust Cache | |
| uses: Swatinem/rust-cache@v2.8.2 | |
| with: | |
| shared-key: cargo-doc | |
| save-if: ${{ github.ref == 'refs/heads/master' }} | |
| - name: Dependencies for 'keyring' | |
| run: sudo ./scripts/install-minimal-debian-dependencies.sh | |
| - name: Check documentation | |
| run: cargo doc --workspace --no-deps --exclude gitbutler-tauri | |
| rust-test: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.rust == 'true' }} | |
| runs-on: ubuntu-latest | |
| env: | |
| CARGO_TERM_COLOR: always | |
| defaults: | |
| run: | |
| shell: bash | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - name: Rust Cache | |
| uses: Swatinem/rust-cache@v2.8.2 | |
| with: | |
| shared-key: cargo-test-no-tauri | |
| save-if: ${{ github.ref == 'refs/heads/master' }} | |
| - name: Dependencies for 'keyring' | |
| run: sudo ./scripts/install-minimal-debian-dependencies.sh | |
| - run: cargo test --workspace --exclude gitbutler-tauri --exclude but-server | |
| env: | |
| GITBUTLER_TESTS_NO_CLEANUP: '1' | |
| # It's intentional to use 'name equals run-script' so it's easy to re-run locally on failure. | |
| - run: cargo test -p but --no-default-features | |
| - run: cargo test -p but-server | |
| rust-test-tauri: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.rust == 'true' }} | |
| runs-on: ubuntu-latest | |
| container: | |
| image: ghcr.io/gitbutlerapp/ci-base-image:latest | |
| env: | |
| CARGO_TERM_COLOR: always | |
| defaults: | |
| run: | |
| shell: bash | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - name: Rust Cache | |
| uses: Swatinem/rust-cache@v2.8.2 | |
| with: | |
| shared-key: cargo-test-tauri | |
| save-if: ${{ github.ref == 'refs/heads/master' }} | |
| - run: | | |
| set -e | |
| cargo check -p gitbutler-tauri --no-default-features | |
| for feature in devtools custom-protocol error-context packaged-but-distribution builtin-but; do | |
| cargo check -p gitbutler-tauri --no-default-features --features "$feature" | |
| done | |
| name: Test Tauri and Check Tauri App Features | |
| check-rust-windows: | |
| needs: changes | |
| runs-on: windows-latest | |
| if: ${{ needs.changes.outputs.rust == 'true' }} | |
| env: | |
| CARGO_TERM_COLOR: always | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - name: Rust Cache | |
| uses: Swatinem/rust-cache@v2.8.2 | |
| with: | |
| shared-key: cargo-test | |
| save-if: ${{ github.ref == 'refs/heads/master' }} | |
| - name: 'cargo check' | |
| run: cargo check --workspace --all-targets --features windows | |
| check-rust: | |
| if: always() | |
| needs: | |
| - changes | |
| - check-rust-windows | |
| - rust-test | |
| - rust-test-tauri | |
| - rust-lint | |
| - cargo-doc | |
| runs-on: ubuntu-latest | |
| env: | |
| CARGO_TERM_COLOR: always | |
| steps: | |
| - name: Decide whether the needed jobs succeeded or failed | |
| uses: re-actors/alls-green@release/v1 | |
| with: | |
| allowed-skips: ${{ toJSON(needs) }} | |
| jobs: ${{ toJSON(needs) }} | |
| # Check that all `actions/checkout` in CI jobs have `persist-credentials: false`. | |
| check-no-persist-credentials: | |
| runs-on: ubuntu-latest | |
| env: | |
| GLOB: .github/workflows/*.@(yaml|yml) | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| sparse-checkout: '.github/workflows' | |
| - name: Generate workflows list to scan | |
| run: | | |
| shopt -s extglob | |
| printf '%s\n' ${{ env.GLOB }} | grep -v .github/workflows/publish.yaml >workflows.list | |
| cat workflows.list | |
| echo "Note that publish.yaml is excluded until it's ensured to not need this feature" | |
| - name: Scan workflows | |
| run: | | |
| shopt -s extglob | |
| yq '.jobs.*.steps[] | |
| | select(.uses == "actions/checkout@*" and .with.["persist-credentials"]? != false) | |
| | {"file": filename, "line": line, "name": (.name // .uses)} | |
| | .file + ":" + (.line | tostring) + ": " + .name | |
| ' -- $(cat workflows.list) >query-output.txt | |
| cat query-output.txt | |
| test -z "$(<query-output.txt)" # Report failure if we found anything | |
| test-ui: | |
| needs: changes | |
| if: ${{ needs.changes.outputs.ui == 'true' }} | |
| runs-on: ubuntu-latest | |
| container: | |
| image: ghcr.io/gitbutlerapp/ci-base-image:latest | |
| env: | |
| CARGO_TERM_COLOR: always | |
| steps: | |
| - uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false | |
| - uses: ./.github/actions/init-env-node | |
| - id: get_playwright_version | |
| uses: eviden-actions/get-playwright-version@v1 | |
| - name: cache playwright binaries | |
| uses: actions/cache@v5 | |
| id: playwright-cache | |
| with: | |
| path: | | |
| ~/.cache/ct-playwright | |
| key: ${{ runner.os }}-playwright-${{ steps.get_playwright_version.outputs.playwright-version }} | |
| - run: cd packages/ui && pnpm exec playwright install --with-deps | |
| if: ${{ steps.playwright-cache.outputs.cache-hit != 'true' }} | |
| - name: run playwright tests | |
| run: pnpm exec turbo run test:ct | |
| if: ${{ github.ref != 'refs/heads/master' }} | |
| - uses: actions/upload-artifact@v6 | |
| if: ${{ !cancelled() }} | |
| with: | |
| name: playwright-report | |
| path: | | |
| ./packages/ui/playwright-report/ | |
| ./packages/ui/test-results/ | |
| retention-days: 30 |