Add require authorization plug #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR @alishir ❤️ This plug duplicates the work of other plugs. Can we instead just see if the result of the validation plugs are present and send the response if not? |
Contributor
Author
|
You are right, let me update the PR. |
Member
|
Awesome. Can you also add a tiny test? |
Contributor
Author
|
Sure, I just added some tests. |
maennchen
approved these changes
Jun 26, 2024
Pull Request Test Coverage Report for Build 34758b50564a869cbd95ca14abf6c2d0ab69b046-PR-21Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 34758b50564a869cbd95ca14abf6c2d0ab69b046-PR-21Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: ⚙ Improvement
about: add require authorization plug as discussed in #20
labels: enhancement