cellmethods parser #125
Draft
cellmethods parser #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgierz
approved these changes
Apr 3, 2025
Member
pgierz
left a comment
There was a problem hiding this comment.
This looks good, and I will mark it as "approve", but I think we should wait to merge it to see how far we want to integrate this: Maybe this can be the first "feature added" release after the main release. What do you think, @mandresm?
It is nice that this is already as a submodule, so it will fit with the new structure as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser generator for cell_methods string attribute in DataArray.
This is prototype work just to investigate if the cell_method string is parsable and good enough to infer some meaningful information so additional steps to processing them can be constructed.