Add JSON value checks for get_parameters.#2039
Merged
Merged
Conversation
Special thanks to Dirk Müller for directing our attention to this.
davidBar-On
reviewed
May 24, 2026
| case 'P': | ||
| test->num_streams = atoi(optarg); | ||
| if (test->num_streams > MAX_STREAMS) { | ||
| if (test->num_streams < 0 || test->num_streams > MAX_STREAMS) { |
Contributor
There was a problem hiding this comment.
I believe that num_streams should be at least 1, as 0 streams is probably meaningless. This is also the default value and in addition iperf_print_results() divides by the value: avg_jitter /= test->num_streams;. (I just happened to see this as the change created a conflict with an old PR I submitted.)
davidBar-On
reviewed
May 24, 2026
| if ((j_p = iperf_cJSON_GetObjectItemType(j, "parallel", cJSON_Number)) != NULL) | ||
| test->num_streams = j_p->valueint; | ||
| if ((j_p = iperf_cJSON_GetObjectItemType(j, "parallel", cJSON_Number)) != NULL){ | ||
| if (j_p->valueint < 0 || j_p->valueint > MAX_STREAMS) { |
Contributor
There was a problem hiding this comment.
As for the P option, num_streams should probably be at least 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more checks and more specific error values to JSON int values in get_parameters.
Special thanks to Dirk Müller for directing our attention to this.
PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":
The complete iperf3 license is available in the
LICENSEfile in thetop directory of the iperf3 source tree.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:Issues fixed (if any):
Adds more checks and specific errors for some of the JSON int values in get_parameters.
Brief description of code changes (suitable for use as a commit message):