[ota] Match client timeout to device timeout to prevent premature failures #12484
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #12484 +/- ##
=======================================
Coverage 72.60% 72.60%
=======================================
Files 53 53
Lines 11192 11192
Branches 1517 1517
=======================================
Hits 8126 8126
Misses 2674 2674
Partials 392 392 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR increases the OTA client socket timeout from 30 seconds to 90 seconds to match the device-side OTA_SOCKET_TIMEOUT_DATA constant. This synchronization prevents premature client disconnects during OTA updates, especially on slower platforms like LibreTiny/Beken where flash write operations take longer. When timeouts are mismatched, the client can give up before the device detects an actual failure, leaving the device OTA state corrupted.
Key Changes
- Updated socket timeout from 30s to 90s in the data transfer phase
- Added clarifying comment referencing the device-side constant
- Maintains existing 20s timeout for the initial connection/handshake phase
|
thanks |
What does this implement/fix?
Increases the OTA client-side socket timeout from 30 seconds to 90 seconds to match the device-side
OTA_SOCKET_TIMEOUT_DATA.When the timeouts don't match, the client can give up waiting for chunk acknowledgments before the device has actually failed. This is particularly problematic on slower platforms like LibreTiny/Beken where flash writes can take longer. The premature timeout causes:
By matching the timeouts, actual failures are detected via proper error responses rather than timeouts.
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# No config changes needed - this fixes OTA reliabilityChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: