Skip to content

Conversation

@dhoeben
Copy link

@dhoeben dhoeben commented Dec 16, 2025

What does this implement/fix?

Now split-up config for a new water_heater component.

This requires more pull requests!

Order of PR:
1: water_heater api/core
2: water_heater component
3: water_heater template
4: water_heater web_server
5: This one

Types of changes

water_heater web_server

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Developer breaking change (an API change that could break external components)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • nRF52840

Example entry for config.yaml:

water_heater:
  - platform: template
    id: my_boiler
    name: "Boiler"
    min_temperature: 10 °C
    max_temperature: 85 °C
    current_temperature: !lambda "return 45.0;"
    mode: !lambda "return water_heater::WATER_HEATER_MODE_ECO;"
    optimistic: true
    visual:
      min_temperature: 10 °C
      max_temperature: 85 °C
      target_temperature_step: 0.5 °C
      current_temperature_step: 0.1 °C

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.63%. Comparing base (ead60bc) to head (0513c68).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #12517      +/-   ##
==========================================
- Coverage   72.66%   72.63%   -0.03%     
==========================================
  Files          53       53              
  Lines       11193    11193              
  Branches     1517     1517              
==========================================
- Hits         8133     8130       -3     
- Misses       2667     2669       +2     
- Partials      393      394       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhoeben dhoeben changed the title [water_heater] Implement tests for new water_heater component [water_heater] (5/5) Implement tests for new water_heater component Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support of water heaters

2 participants