Skip to content

Handling when Monaco throws an exception related to cancel #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
travjenkins wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Handling when Monaco throws an exception related to cancel #1848

travjenkins wants to merge 3 commits into from

Conversation

@travjenkins
Copy link
Member

@travjenkins travjenkins commented Dec 18, 2025 •
edited
Loading

Issues

#1845

Changes

1845

  • Adding a listener for monaco editor's Cancel exceptions.

Misc

  • Proper clean up of eCharts resize listeners

Tests

Manually tested

  • Lots of random resizing of graphs
  • Spamming paste in monaco editor
  • Clicking between history tab and others quickly

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

Spamming paste to see error is now handled

image

@travjenkins
Handling when Monaco throws an exception related to cancel
2cde944 
Better clean up of resize listeners for the graphs
travjenkins
travjenkins commented Dec 18, 2025
View reviewed changes
src/components/editor/MonacoEditor/types.ts
Copy link
Member Author

@travjenkins travjenkins Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was in the file so moving types out.

@travjenkins travjenkins marked this pull request as ready for review December 18, 2025 22:06
@travjenkins travjenkins requested a review from a team as a code owner December 18, 2025 22:06
@travjenkins travjenkins added the change:planned This is a planned change label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregorShear GregorShear Awaiting requested review from GregorShear

@kiahna-tucker kiahna-tucker Awaiting requested review from kiahna-tucker

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

change:planned This is a planned change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@travjenkins