Solver: stop solving ocaml constraint separately#1597
Conversation
|
I wonder how this would affect the solver performance. What's the rationale for that change? |
|
This fails But the following works Working on a fast test to repro this. |
|
Error message was, |
|
I wonder if the proper fix is to ask user to specify a concrete OCaml version. Maybe not through the package.json but interactively on the first project install? |
I think this is possible. If they specify the exact OCaml, follow the ocaml-specific solver flow.. If a semver range is provided, let the solver solve ocaml as any other package. |
|
Yeah, in general it's just there are two types of ocaml constraints right now:
I believe having 2. as specific as possible is a good thing because:
|
Informed users: yes. But there's always someone who forgets, didn't read the documentation or simply disagrees with with the idea of (or finds it inconvenient) having to specify the exact version of ocaml compiler. I'll see if it's possible to accomodate them as well. |
I suppose it is still a very rare case, only for fresh projects, as ocaml version is locked in esy.lock. Maybe exactly for this case an interactive selector could be present. |
|
Are you suggesting that this interactive selector is triggered when the user hasn't specified the exact compiler version instead of trying to club |
|
Yes, basically if the following criteria are met:
then user is asked to select an OCaml version from available. |
f0c12b8 to
f2c1a19
Compare
b619750 to
b9150da
Compare
b9150da to
3c64ef3
Compare
No description provided.