Component | Graph: Fix node coordinate flickering #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure nodes have valid x/y coordinates before layout calculation to prevent flickering when coordinates are undefined/NaN during initial render, layout changes, or dynamic node additions.
|
CLA Assistant Lite bot ✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
|
I have hereby read the F5 CLA and agree to its terms |
Author
|
recheck |
Author
|
well after more validation. this improves but doesn't fix the issue. |
Collaborator
|
@itai-gendler thanks for the contribution! We will take a look at this. |
Contributor
|
@itai-gendler Do you happen to have a reproducible example? I wonder why the nodes have undefined/NaN coordinates in the first place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Nodes flicker to (0,0) or spiral positions during initial render, layout changes, or when adding nodes dynamically. This happens when node coordinates are undefined/NaN.
Solution
Ensure all nodes have valid x/y coordinates (defaulting to graph center) before layout calculation. This prevents D3's force simulation from initializing nodes at invalid positions.
Changes
_calculateLayout()before any layout algorithm runswidth/2,height/2)Testing