-
Notifications
You must be signed in to change notification settings - Fork 94
feat: Add T85* smart lock support - Fixes #1365 #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
JoshuaSeidel
commented
Aug 4, 2025
- Add automatic detection of T85* devices as locks
- Ensure T85* devices have required lock properties and metadata
- Support for C30 (T85D0C), E31 (T85F0), S3 max (T85V0) smart locks
- Maintains backward compatibility with existing devices
- T85* devices now provide standard lock/unlock functionality
- Add automatic detection of T85* devices as locks - Ensure T85* devices have required lock properties and metadata - Support for C30 (T85D0C), E31 (T85F0), S3 max (T85V0) smart locks - Maintains backward compatibility with existing devices - T85* devices now provide standard lock/unlock functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution and solution you presented here.
I believe that fixing the issue from the eufy-security-client is much better solution, what do you think?
https://bropat.github.io/eufy-security-client/#/supported_devices
One example onboarding: bropat/eufy-security-client@f53b816#diff-1d41569873ee36d129f6bbd614e677fcd20edc2a36be2f5b9371081faec87f67
the locks that were not working in this solution are listed as supported in eufy-security-client. |
so, you had the lock entities in home assistant but they were not functioning properly?
there are many other consumers of eufy-security-client and that would help many other people |
|
|
||
| # Ensure T85* devices have the locked property | ||
| if serial_no.startswith("T85") and MessageField.LOCKED.value not in properties: | ||
| properties[MessageField.LOCKED.value] = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might cause some issues for initial state, it will be always visible as locked at startup.
I am also expecting that some other T85** devices are supported out of the box, this would overwrite their state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure the fix, i used cursor with genai to add this functionality
| return self.serial_no.startswith("T85") | ||
|
|
||
| @property | ||
| def is_lock(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we use this?
the locks showed up, without the lock entity. so we couldnt control the lock, only view some very vague statuses. |
|
Do you want to take this up within eufy-security-client? I can show you the exact code pointer so it could work natively. Or else, can you share your lock with me temporarily (within a schedule) so I can do it |
@fuatakgun yea i can share one of my locks with you on a schedule. how do i do that? |
I have T85V0 (S3 Max) if I can assist with data collection or testing (via Home Assistant). In addition to the lock functions it is a video doorbell. |
|
I also have T85V0 (S3 Max) I attempted to insert the code change to my HA instance. While the lock entity showed up after enabling it. The lock itself did not unlock/lock. Was getting a "device_invalid_property" error. |
|
Any update on this? I also have a Video Smart Lock E330. I can help with dev if needed given some pointers or guidance @fuatakgun |
|
@JoshuaSeidel I have your fork running on my HACS but still doesnt seem like the T85D0 is supported |