You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Idea for discussion: right now we only run the github CI as part of a PR but not in response to a push. This means (at least in my case :) PRs get filed that feel correct locally but then fail many times in the CI as dependencies and whatnot need to get sorted out.
With the automatic review requests on PRs this means a lot of spam to maintainers for stuff that just isn't ready quite yet.
So I'm wondering: why not run the CI as part of a push pipeline too? AIUI some parts of the CI ping the LVFS to download emulations1 but if we flip the toggles to only run the basic tests in push pipelines this would be quite helpful already.
This would allow contributors to push, check the CI, and then file the PR when the initial CI succeeds - any subsequent failures would then be true failures during the emulation stage.
Thoughts?
Footnotes
should really be part of the container image but that's a separate story. ↩
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Idea for discussion: right now we only run the github CI as part of a PR but not in response to a push. This means (at least in my case :) PRs get filed that feel correct locally but then fail many times in the CI as dependencies and whatnot need to get sorted out.
With the automatic review requests on PRs this means a lot of spam to maintainers for stuff that just isn't ready quite yet.
So I'm wondering: why not run the CI as part of a push pipeline too? AIUI some parts of the CI ping the LVFS to download emulations1 but if we flip the toggles to only run the basic tests in push pipelines this would be quite helpful already.
This would allow contributors to push, check the CI, and then file the PR when the initial CI succeeds - any subsequent failures would then be true failures during the emulation stage.
Thoughts?
Footnotes
should really be part of the container image but that's a separate story. ↩
All reactions