trivial: Move FuQsiDockFirmwareIdx to Rust format #9686
Merged
+66
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR migrates the QSI Dock plugin's C header definitions to Rust format. The migration converts enums and structs from C to Rust, following fwupd's pattern of using Rust for structure definitions while maintaining C compatibility through generated headers.
Key changes:
- Converted
FuQsiDockFirmwareIdx,FuQsiDockCmd1,FuQsiDockCmd2Cmd,FuQsiDockCmd2Spienums from C to Rust - Converted
FuQsiDockIspVersionInMcustruct from C to Rust - Updated meson.build to include Rust code generation
- Removed the old C header file
fu-qsi-dock-common.h
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/qsi-dock/meson.build | Added rustgen.process() for the new Rust file |
| plugins/qsi-dock/fu-qsi-dock.rs | New Rust file containing migrated enums and struct definitions |
| plugins/qsi-dock/fu-qsi-dock-mcu-device.c | Updated include from fu-qsi-dock-common.h to fu-qsi-dock-struct.h (generated), updated constant references |
| plugins/qsi-dock/fu-qsi-dock-common.h | Deleted - replaced by Rust definitions |
185fb24 to
b03c208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request: