Update wavelengthIndex description for processed data#175
Open
sreekanthkura7 wants to merge 2 commits into
Open
Update wavelengthIndex description for processed data#175sreekanthkura7 wants to merge 2 commits into
sreekanthkura7 wants to merge 2 commits into
Conversation
Clarified requirements for wavelengthIndex in processed data.
HanBnrd
approved these changes
Jan 26, 2026
HanBnrd
left a comment
Member
There was a problem hiding this comment.
Thanks @sreekanthkura7, good catch! Looks good to me!
Collaborator
|
I guess this change would require a respective adjustment in the validator, right? Is @sstucker still the designated validator maintainer? |
|
is this the final convention that has been decided on? Some readers have made their own convention, e.g. Cedalion uses -1 https://github.com/ibs-lab/cedalion/blob/main/src/cedalion/io/snirf.py#L1003 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarified requirements for wavelengthIndex in processed data.
Closes #174