Skip to content

Fix Gradle warnings #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MGaetan89 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Gradle warnings #1053

MGaetan89 wants to merge 1 commit into from

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented May 20, 2025

Summary

This PR fixes some warnings in Gradle files, in particular:

  • Use configureEach instead of all to favor lazy access to objects.
  • Use Task.register() for creating new tasks.
  • Use imports instead of fully qualified class names.
  • Move the dependencies block out of the android block.
  • Move the TODO for Lint error back where it belongs.

Changelog

Fix Gradle warnings.

Test Plan

GitHub Actions workflow run is successful (minus the currently failing tests).

@MGaetan89 MGaetan89 marked this pull request as ready for review May 20, 2025 05:35
@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch 2 times, most recently from 463478e to 1548788 Compare May 22, 2025 14:17
@MGaetan89
Copy link
Contributor Author

MGaetan89 commented May 22, 2025

I've updated the PR with the latest changes from master and the build is ✅ now.
Let me know if something else is needed for this PR.

@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch 4 times, most recently from 3070fd5 to e97c2d1 Compare June 1, 2025 14:52
@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch from e97c2d1 to 6fac055 Compare June 2, 2025 09:41
@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Jun 2, 2025

The PR has been updated with the latest changes from master and it is green again ✅

@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch 3 times, most recently from 7a517b7 to e6ebdad Compare June 5, 2025 06:42
@MGaetan89 MGaetan89 mentioned this pull request Jun 5, 2025
Closed
@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch 5 times, most recently from 470de69 to e724863 Compare June 12, 2025 07:19
@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch from e724863 to bcae810 Compare June 13, 2025 08:09
@MGaetan89 MGaetan89 mentioned this pull request Jun 13, 2025
Open
@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch 5 times, most recently from 55e5883 to f358e7e Compare June 20, 2025 08:41
@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch 3 times, most recently from 8b3927b to cda3c0d Compare June 27, 2025 12:04
@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch 4 times, most recently from cd39d9e to ed54504 Compare July 7, 2025 12:36
@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch 2 times, most recently from e7ec330 to 84c7afb Compare July 15, 2025 08:16
@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Jul 15, 2025

@zielinskimz I've updated the PR to include the latest changes from master

@MGaetan89 MGaetan89 force-pushed the fix_gradle_warnings branch from 84c7afb to 7c62c78 Compare July 21, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MGaetan89 @facebook-github-bot