Skip to content

Fix build on GitHub #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MGaetan89 wants to merge 1 commit into from
Closed

Fix build on GitHub #1064

MGaetan89 wants to merge 1 commit into from

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Jun 25, 2025

Summary

This commit fixes the build on GitHub:

  • NodeDescriptor#init(T) was missing the nullability on T in Kotlin overrides.
  • Some nullability checks were missing in DebugComponentDescriptor.

Changelog

Fix build on GitHub.

Test Plan

The build is successful on GitHub.

@MGaetan89 MGaetan89 marked this pull request as ready for review June 25, 2025 11:46
@MGaetan89
Fix build on GitHub
0e49bf2 
This commit fixes the build on GitHub:
- `NodeDescriptor#init(T)` was missing the nullability on `T` in Kotlin overrides.
- Some nullability checks were missing in `DebugComponentDescriptor`.
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 27, 2025

@apowolny has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 27, 2025

@apowolny merged this pull request in 0857f04.

@MGaetan89 MGaetan89 deleted the fix_build branch June 27, 2025 12:03
@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Jun 27, 2025

@apowolny it seems that the change in the signature of the init() method was not part of the merge. Is there any reason for that?
The build on master is still failing because of that:

e: file:///home/runner/work/litho/litho/litho-editor-flipper/src/main/java/com/facebook/litho/editor/flipper/DebugComponentDescriptor.kt:56:1 Class 'DebugComponentDescriptor' is not abstract and does not implement abstract base class member public abstract fun init(p0: DebugComponent?): Unit defined in com.facebook.flipper.plugins.inspector.NodeDescriptor
e: file:///home/runner/work/litho/litho/litho-editor-flipper/src/main/java/com/facebook/litho/editor/flipper/DebugComponentDescriptor.kt:102:3 'init' overrides nothing
e: file:///home/runner/work/litho/litho/litho-editor-flipper/src/main/java/com/facebook/litho/editor/flipper/DebugSectionDescriptor.kt:38:1 Class 'DebugSectionDescriptor' is not abstract and does not implement abstract base class member public abstract fun init(p0: DebugSection?): Unit defined in com.facebook.flipper.plugins.inspector.NodeDescriptor
e: file:///home/runner/work/litho/litho/litho-editor-flipper/src/main/java/com/facebook/litho/editor/flipper/DebugSectionDescriptor.kt:56:29 'init' overrides nothing
e: file:///home/runner/work/litho/litho/litho-editor-flipper/src/main/java/com/facebook/litho/editor/flipper/LithoViewDescriptor.kt:31:1 Class 'LithoViewDescriptor' is not abstract and does not implement abstract base class member public abstract fun init(p0: BaseMountingView?): Unit defined in com.facebook.flipper.plugins.inspector.NodeDescriptor
e: file:///home/runner/work/litho/litho/litho-editor-flipper/src/main/java/com/facebook/litho/editor/flipper/LithoViewDescriptor.kt:34:3 'init' overrides nothing

@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Jun 30, 2025

I see it was fixed in #1066 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apowolny apowolny apowolny approved these changes

Assignees

No one assigned

Labels

CLA Signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MGaetan89 @facebook-github-bot @apowolny