Skip to content

add option to constrain fabio instance to specific consul namespace#812

Merged
tristanmorgan merged 2 commits into
fabiolb:masterfrom
baabgai:consul_namespace
Jun 11, 2025
Merged

add option to constrain fabio instance to specific consul namespace#812
tristanmorgan merged 2 commits into
fabiolb:masterfrom
baabgai:consul_namespace

Conversation

@baabgai

@baabgai baabgai commented Jan 11, 2021

Copy link
Copy Markdown

This helps to use fabio in a multi tenant environment by allowing to register a fabio instance in a specific consul namespace. All services that will be picked up with the specified tagprefix by this instance only come from the same consul namespace.

@CLAassistant

CLAassistant commented Jan 11, 2021

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tristanmorgan
❌ alexander-fuchs-cistec
You have signed the CLA already but the status is still pending? Let us recheck it.

@ketzacoatl

Copy link
Copy Markdown

@leprechau / @pschultz / @nathanejohnson, is this contribution you would want to see in fabio? It seems useful to those of us running multiple fabio instances (each with their own tagprefix), or looking to isolate groups of services/traffic.

@pschultz

pschultz commented Feb 3, 2021

Copy link
Copy Markdown
Member

Seems very useful to me. I just can't help with the review/testing, because we're not an enterprise customer.

@nathanejohnson

Copy link
Copy Markdown
Member

I can see this being useful, but like @pschultz we are not enterprise customers so I can't test or vet this PR.

@ketzacoatl

Copy link
Copy Markdown

I'm not a gopher, so my review of the code would be meaningless. Would you be able to do a code review?

I could run tests to confirm the expected behavior.

@pschultz

pschultz commented Feb 4, 2021

Copy link
Copy Markdown
Member

The code looks fine to me. It's a pretty obvious and natural change. What I can't judge is if there are any missing places where the namespace has to be respected, but should become apparent with testing.

@aaronhurt

Copy link
Copy Markdown
Member

@baabgai are you using this patch in your environment? Can you confirm operation?

@baabgai

baabgai commented May 21, 2021

Copy link
Copy Markdown
Author

Hi @leprechau,
Yes we're using it at the moment in production and until now we didn't experience any issues with namespace addition. To be fair I have to mention that we're still in the process of setting up a multi tenant cluster where this component is used and the current production load is still rather low.

@nathanejohnson nathanejohnson force-pushed the master branch 2 times, most recently from a55de9d to 04f958c Compare April 11, 2022 18:45
@tristanmorgan tristanmorgan self-assigned this May 7, 2025
@tristanmorgan tristanmorgan requested a review from a team as a code owner June 11, 2025 04:34

@tristanmorgan tristanmorgan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against latest Consul Enterprise and CE.

@tristanmorgan tristanmorgan merged commit 34f29f5 into fabiolb:master Jun 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants