Skip to content

updating godeps#969

Merged
tristanmorgan merged 1 commit into
fabiolb:masterfrom
aleksraiden:update-deps-43
Feb 13, 2025
Merged

updating godeps#969
tristanmorgan merged 1 commit into
fabiolb:masterfrom
aleksraiden:update-deps-43

Conversation

@aleksraiden

Copy link
Copy Markdown
Contributor

Update godeps to latest (as possible).

Currently, fabio deps cant be updated directly, like go get -u ./... because we have two "points-of-pain":

A first - armon/go-proxyproto and inetaf/tcpproxy cant be upgraded

Second - a part, working with zipkin and tracing. A newest version of tracing have a lot of changes in API, so we need a rewrite core logic into tracing module and test. A package, affected this: openzipkin-contrib/zipkin-go-opentracing, openzipkin/zipkin-go and apache/thrift.

@tristanmorgan

Copy link
Copy Markdown
Member

On a side note, I've been looking at replacing github.com/armon/go-proxyproto with github.com/pires/go-proxyproto but I have a troubling test to get working.

@tristanmorgan tristanmorgan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well, Thanks for the contribution.

@tristanmorgan tristanmorgan merged commit 0f7da1e into fabiolb:master Feb 13, 2025
@aleksraiden aleksraiden deleted the update-deps-43 branch February 14, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants