Skip to content

Conversation

@sohamsshah
Copy link
Contributor

Closes #135

This PR adds docs/ to .npmignore file to prevent it to be published to npm.

@netlify
Copy link

netlify bot commented Jan 14, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: ebd5222

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e14933fdc07f0008ae34dd

😎 Browse the preview: https://deploy-preview-139--vigilant-wescoff-04e480.netlify.app

@prisis
Copy link
Member

prisis commented Jan 14, 2022

Can you change the Pr title to fix: add docs to .npmignore

@sohamsshah sohamsshah changed the title add docs to .npmignore fix: add docs to .npmignore Jan 14, 2022
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit c5404be into faker-js:main Jan 14, 2022
@ejcheng ejcheng added the c: chore PR that doesn't affect the runtime behavior label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent docs folder from being published to npm

5 participants