feat: migrate mocha #186
feat: migrate mocha #186
Conversation
|
✔️ Deploy Preview for vigilant-wescoff-04e480 ready! 🔨 Explore the source changes: b17074d 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e4d05640ba5d0007e4f7ec 😎 Browse the preview: https://deploy-preview-186--vigilant-wescoff-04e480.netlify.app |
| "lint": "echo 'TODO eslint'", | ||
| "test": "mocha test/*.*.js" | ||
| "test": "mocha --require ts-node/register ./test/*.spec.ts", | ||
| "test:js": "mocha test/*.*.js" |
There was a problem hiding this comment.
I think you're also going to want to add this new command to the Github Testing CI Action (https://github.com/faker-js/faker/blob/main/.github/workflows/ci.yml) to ensure the tests still run during CI :)
There was a problem hiding this comment.
I was thinking we could use this branch to migrate the tests in full. Not sure the other contributors wanted to move forward with that. But we can also run both the JS tests and TS tests, so we can PR on main instead, and just increase the number of tests?
There was a problem hiding this comment.
It might be nice to just branch off main, that may prevent us from losing tests from other PRs that may concurrently add, and then we could run both js and ts tests for now.
|
I will close this because we will directly migrate the tests to vitest #235 |
No description provided.