fix(types): fixed datetime types for optional argument #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vigilant-wescoff-04e480 ready! 🔨 Explore the source changes: d0cce58 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e524db93201c0008702eb0 😎 Browse the preview: https://deploy-preview-192--vigilant-wescoff-04e480.netlify.app |
Shinigami92
reviewed
Jan 17, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
prisis
reviewed
Jan 17, 2022
Shinigami92
approved these changes
Jan 17, 2022
prisis
approved these changes
Jan 18, 2022
Shinigami92
added a commit
to MohdImran001/faker
that referenced
this pull request
Jan 18, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
pkuczynski
pushed a commit
to pkuczynski/faker
that referenced
this pull request
Jan 21, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datetime has an optional
optionsargumentsource: https://github.com/faker-js/faker/blob/main/src/datatype.ts#L98
test:
faker/test/datatype.unit.js
Line 157 in d9b6e5d
@types/faker: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/b5bf4061b0811d2e16dc3c6b4c3c15881b73290f/types/faker/index.d.ts#L107