Skip to content

chore(test): Add locale to test description #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prisis merged 1 commit into from
Jan 23, 2022
Merged

chore(test): Add locale to test description #262

prisis merged 1 commit into from
Jan 23, 2022

Conversation

@ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 23, 2022 •
edited
Loading

This improves the generic tests by adding the locale to the the test description.

Before:

stdout | test/all_functional.spec.ts > functional tests > random > hexaDecimal()

After:

stdout | test/all_functional.spec.ts > functional tests > en_AU_ocker > random > hexaDecimal()

This PR can be reviewed best without showing whitespace changes. (There is a button for that in the github ui)

@ST-DDT ST-DDT requested a review from a team as a code owner January 23, 2022 10:01
Shinigami92
Shinigami92 approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Shinigami92 Shinigami92 requested a review from a team January 23, 2022 10:03
@prisis prisis added this to the v6.0.0 - Project stability milestone Jan 23, 2022
@prisis prisis merged commit 6ba72a4 into faker-js:main Jan 23, 2022
@ST-DDT ST-DDT deleted the test/add-locale-to-test-description branch January 23, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prisis prisis prisis approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@ST-DDT ST-DDT

Labels

c: test

Projects

None yet

Milestone

v6.0 - Ensure Project Foundation

Development

Successfully merging this pull request may close these issues.

3 participants

@ST-DDT @prisis @Shinigami92