Skip to content

feat: update sponsors, backers references #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
damienwebdev merged 1 commit into from
Jan 10, 2022
Merged

feat: update sponsors, backers references #30

damienwebdev merged 1 commit into from
Jan 10, 2022

Conversation

@clarkerican
Copy link
Contributor

@clarkerican clarkerican commented Jan 8, 2022 •
edited
Loading

Removes sponsors, and backers from the Readme

@damienwebdev
Copy link
Member

damienwebdev commented Jan 9, 2022

@clarkerican can you split this diff apart? Some of this relates to:

  1. README modifications from Replace all FakerCloud links with a new source #28
  2. Support for self-managed types Rewrite in typescript and emit usable types #14
  3. Package renaming chore: acquire ownership of npm org #19

And I think we should strive to target one issue at a time.

@clarkerican clarkerican force-pushed the erica/update-maintainers-sponsers-backers branch from e5202c1 to 657c180 Compare January 9, 2022 01:59
@clarkerican clarkerican changed the title feat: update sponsors, backers references, and add index.d.ts feat: update sponsors, backers references Jan 9, 2022
@clarkerican
Copy link
Contributor Author

clarkerican commented Jan 9, 2022

@damienwebdev I limited the scope :)

damienwebdev
damienwebdev approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Shinigami92
Shinigami92 reviewed Jan 9, 2022
View reviewed changes
Shinigami92
Shinigami92 reviewed Jan 9, 2022
View reviewed changes
@Shinigami92
Copy link
Member

Shinigami92 commented Jan 9, 2022

Should we remove .github/FUNDING.yml also at least for now?

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 9, 2022
Shinigami92
Shinigami92 requested changes Jan 9, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments above

@Shinigami92 Shinigami92 mentioned this pull request Jan 9, 2022
Closed
@Shinigami92 Shinigami92 force-pushed the erica/update-maintainers-sponsers-backers branch from 99b6b26 to 47c5e10 Compare January 10, 2022 19:16
damienwebdev
damienwebdev approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 2b9d8c6 into main Jan 10, 2022
@damienwebdev damienwebdev deleted the erica/update-maintainers-sponsers-backers branch January 10, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prisis prisis prisis approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@damienwebdev damienwebdev damienwebdev approved these changes

@mmahalwy mmahalwy Awaiting requested review from mmahalwy

Assignees

No one assigned

Labels

c: chore PR that doesn't affect the runtime behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@clarkerican @damienwebdev @Shinigami92 @prisis