Skip to content

Conversation

@ejcheng
Copy link
Member

@ejcheng ejcheng commented Jan 26, 2022

Fixes #295

@ejcheng ejcheng requested review from a team, Shinigami92, damienwebdev and prisis January 26, 2022 01:12
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to replace all links like in markdown files with new url

@Shinigami92 Shinigami92 marked this pull request as draft January 26, 2022 06:17
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 26, 2022
@ejcheng
Copy link
Member Author

ejcheng commented Jan 26, 2022

You need to replace all links like in markdown files with new url

Could you please clarify what you mean by this? I interpreted your instructions as "replace all instances of fakerjs.dev with chat.fakerjs.dev in markdown files", but I don't think that makes sense.

@Shinigami92
Copy link
Member

[![Chat on Discord](https://img.shields.io/discord/929487054990110771)](https://discord.com/invite/4qDjAmDj4P)

Just one example, please search over the whole repo

@ejcheng
Copy link
Member Author

ejcheng commented Jan 26, 2022

3242dfc/README.md?plain=1#L6

Just one example, please search over the whole repo

Ohhh I see, will do.

Edit: done

@ejcheng ejcheng marked this pull request as ready for review January 26, 2022 18:18
@ejcheng ejcheng requested a review from Shinigami92 January 26, 2022 18:19
@ejcheng ejcheng marked this pull request as draft January 26, 2022 18:19
@ejcheng ejcheng marked this pull request as ready for review January 26, 2022 18:20
@ejcheng
Copy link
Member Author

ejcheng commented Jan 26, 2022

Whoops, misclick.

@ejcheng ejcheng requested a review from ST-DDT January 26, 2022 19:07
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@ST-DDT ST-DDT requested a review from a team January 26, 2022 20:01
@Shinigami92 Shinigami92 merged commit 32b4839 into faker-js:main Jan 28, 2022
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: 1-normal Nothing urgent

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

chat.fakerjs.dev

3 participants