Skip to content

chore: welcome only new issue creators #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Shinigami92 merged 2 commits into from
Feb 1, 2022
Merged

chore: welcome only new issue creators #338

Shinigami92 merged 2 commits into from
Feb 1, 2022

Conversation

@pkuczynski
Copy link
Member

@pkuczynski pkuczynski commented Jan 28, 2022

Following discussion this is an attempt to avoid creating the welcome message all the time. See https://actions-cool.github.io/issues-helper/en-US/base#welcome for more details. I also raised actions-cool/issues-helper#102 to see if there are other alternatives...

Alternatively, we could use different action for this purpose, for example https://github.com/marketplace/actions/welcome-new-contributors

@pkuczynski pkuczynski requested a review from a team as a code owner January 28, 2022 19:30
@pkuczynski pkuczynski added the c: chore PR that doesn't affect the runtime behavior label Jan 28, 2022
@pkuczynski pkuczynski added this to the v6.0 - Project stability milestone Jan 28, 2022
@ST-DDT ST-DDT requested a review from a team January 28, 2022 22:37
@Shinigami92
Copy link
Member

Shinigami92 commented Jan 29, 2022

We can test it out, but I'm not sure if this is really the thing we wanted.
I copied the workflow over from Vite, and there we have this "problem" also, and decided to add the ... or another community member to the message.
The help wanted label also indicates more an intent to be visible by sites like http://github-help-wanted.com/
A solution if this PR does not work as intended would be to just ignore as internal contributor.

@pkuczynski
Copy link
Member Author

pkuczynski commented Jan 29, 2022

Help wanted should be still applied. If am not mistaken the only diff between welcome and create comment is that the first one does this only once per user...

Maybe I am wrong but it's wort to try. We can always revert if this does not work :)

@Shinigami92
Copy link
Member

Shinigami92 commented Feb 1, 2022

we will just test it, if hell breaks lose we can revert it :P

@Shinigami92 Shinigami92 merged commit fdfea0d into faker-js:main Feb 1, 2022
@pkuczynski pkuczynski deleted the issue-labelling branch February 1, 2022 23:31
@Shinigami92 Shinigami92 mentioned this pull request Feb 18, 2022
Merged
1 task
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
@pkuczynski @bmenant
chore: welcome only new issue creators (faker-js#338)
4344af4
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@pkuczynski @demipel8
chore: welcome only new issue creators (faker-js#338)
1a7bb7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis prisis approved these changes

@ejcheng ejcheng ejcheng approved these changes

Assignees

@pkuczynski pkuczynski

Labels

c: chore PR that doesn't affect the runtime behavior

Projects

None yet

Milestone

v6.0 - Ensure Project Foundation

Development

Successfully merging this pull request may close these issues.

5 participants

@pkuczynski @Shinigami92 @ST-DDT @prisis @ejcheng