Skip to content

feat(locale): add Japanese date and month definitions #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xDivisionByZerox merged 2 commits into from
Apr 29, 2025
Merged

feat(locale): add Japanese date and month definitions #3492

xDivisionByZerox merged 2 commits into from
Apr 29, 2025

Conversation

@matsueushi
Copy link
Contributor

@matsueushi matsueushi commented Apr 26, 2025

Added date definitions for Japanese locale

@matsueushi matsueushi requested a review from a team as a code owner April 26, 2025 14:26
@netlify
Copy link

netlify bot commented Apr 26, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 985cab0
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6810f221cef7110008491b75
😎 Deploy Preview https://deploy-preview-3492.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Apr 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (786a3d0) to head (985cab0).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3492   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2866     2869    +3     
  Lines      219789   219832   +43     
  Branches      952      950    -2     
=======================================
+ Hits       219736   219779   +43     
  Misses         53       53
Files with missing lines Coverage Δ
src/locales/ja/date/index.ts 100.00% <100.00%> (ø)
src/locales/ja/date/month.ts 100.00% <100.00%> (ø)
src/locales/ja/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/ja/index.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: date Something is referring to the date module labels Apr 29, 2025
@xDivisionByZerox xDivisionByZerox added this to the v9.x milestone Apr 29, 2025
@xDivisionByZerox xDivisionByZerox merged commit b70e793 into faker-js:next Apr 29, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matsueushi matsueushi

Labels

c: locale Permutes locale definitions m: date Something is referring to the date module p: 1-normal Nothing urgent

Projects

None yet

Milestone

v9.x

Development

Successfully merging this pull request may close these issues.

4 participants

@matsueushi @matthewmayer @Shinigami92 @xDivisionByZerox