chore: add discord link to fakerjs.dev navbar #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prisis
approved these changes
Jan 29, 2022
Member
|
Just a note, for me it would be a p2-nice-to-have |
Shinigami92
approved these changes
Jan 29, 2022
Member
Shinigami92
left a comment
There was a problem hiding this comment.
For now I think this is okay
But later we may want to embed it into a submenu like in the current Vue docs, or in the next Vitepress seems, there is the possibility to embed an Discord icon next to Twitter and GitHub
ST-DDT
approved these changes
Jan 29, 2022
Member
Author
Yeah, this is okay for now, but we should change it to use icons like the site you linked in the future. On another note, wow, that site looks amazing! |
bmenant
pushed a commit
to bmenant/faker
that referenced
this pull request
Mar 11, 2022
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this would help get more people into the Discord server and facilitate a better community.