feat(github): add github actions #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It's a start and we can improve it later on 👍 |
Member
|
What node versions should we support? |
Member
|
before end of march: 12, 14, 16 and 17 + mac 16 + win 16 But do we have relevant stuff for differences between unix and win? |
Member
|
For references: |
Shinigami92
reviewed
Jan 9, 2022
damienwebdev
requested changes
Jan 9, 2022
Shinigami92
requested changes
Jan 9, 2022
Member
|
It's currently expected that CI test are failing! |
damienwebdev
approved these changes
Jan 9, 2022
Shinigami92
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for #1
I just added testing and linting for now.