Skip to content

docs: fix JSDoc comments in commerce.ts #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Shinigami92 merged 25 commits into from
Feb 10, 2022
Merged

docs: fix JSDoc comments in commerce.ts #351

Shinigami92 merged 25 commits into from
Feb 10, 2022

Conversation

@ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 29, 2022

Refs #203

@ST-DDT ST-DDT added c: feature Request for new feature c: dependencies Pull requests that adds/updates a dependency labels Jan 29, 2022
@ST-DDT ST-DDT self-assigned this Jan 29, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner January 29, 2022 15:53
Shinigami92
Shinigami92 previously approved these changes Jan 29, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team January 29, 2022 16:11
@Shinigami92 Shinigami92 removed the c: dependencies Pull requests that adds/updates a dependency label Jan 29, 2022
@ST-DDT ST-DDT added the c: docs Improvements or additions to documentation label Jan 29, 2022
@ST-DDT ST-DDT requested a review from Shinigami92 January 29, 2022 18:11
Shinigami92
Shinigami92 previously approved these changes Jan 29, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team January 29, 2022 19:52
@Shinigami92 Shinigami92 requested a review from a team January 31, 2022 08:05
@ST-DDT ST-DDT mentioned this pull request Feb 1, 2022
Closed
pkuczynski
pkuczynski reviewed Feb 1, 2022
View reviewed changes
@ST-DDT ST-DDT changed the title chore: fix JSDoc comments in commerce.ts docs: fix JSDoc comments in commerce.ts Feb 1, 2022
@pkuczynski pkuczynski mentioned this pull request Feb 2, 2022
Merged
@ST-DDT ST-DDT requested a review from a team February 2, 2022 17:35
@codecov
Copy link

codecov bot commented Feb 6, 2022 •
edited
Loading

Codecov Report

Merging #351 (5f005fa) into main (c208777) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5f005fa differs from pull request most recent head 474b2e7. Consider uploading reports for the commit 474b2e7 to get more accurate results

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files        1920     1920              
  Lines      174378   174394      +16     
  Branches      896      896              
==========================================
+ Hits       173219   173234      +15     
- Misses       1103     1104       +1     
  Partials       56       56
Impacted Files Coverage Δ
src/commerce.ts 100.00% <100.00%> (ø)
src/helpers.ts 99.30% <0.00%> (-0.18%) ⬇️

@Shinigami92 Shinigami92 merged commit 833ac3c into main Feb 10, 2022
@Shinigami92 Shinigami92 deleted the jsdoc/commerce branch February 10, 2022 22:57
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@ST-DDT @demipel8
docs: fix JSDoc comments in commerce.ts (faker-js#351)
f62a37c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkuczynski pkuczynski pkuczynski approved these changes

@prisis prisis prisis approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

+1 more reviewer

@brettz9 brettz9 brettz9 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ST-DDT ST-DDT

Labels

c: docs Improvements or additions to documentation c: feature Request for new feature

Projects

None yet

Milestone

v6.0 - Ensure Project Foundation

Development

Successfully merging this pull request may close these issues.

6 participants

@ST-DDT @brettz9 @pkuczynski @prisis @Shinigami92