✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	4673ec3
🔍 Latest deploy log	https://app.netlify.com/projects/fakerjs/deploys/6861b07503ae74000811ee6e
😎 Deploy Preview	https://deploy-preview-3531.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Hi @DanielShvarts2004 👋
First, let me thank you for your contribution.

The tests in the pipeline are failing, because the locale data you provided contain duplicate values. Can you remove them?
Also, your PR titles does currently not follow our guidelines. Please have a look at our CONTRIBUTING guidelines for more information.

If you need help with anything, feel free to ask :)

Hey thank you for your helpful response 🙏
Just fixed the dups and the title .

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (bf3fe92) to head (4673ec3).
Report is 1 commits behind head on next.

@@            Coverage Diff             @@
##             next    #3531      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2880     2888       +8     
  Lines      220510   222112    +1602     
  Branches      951      952       +1     
==========================================
+ Hits       220457   222053    +1596     
- Misses         53       59       +6     

Of course! Love the idea

I don't know how similar pt_PT and pt_BR are. Could we use the same word lists for pt_PT?

@matthewmayer
pt_PT and pt_BR are similar but have some differences. We definitely can make your suggestion, but it might not be 100% accurate. Let me know what you think. I can copy those words to pt_PT.

(If we would do that, why do we need them both and not expose one pt locale?)

@matthewmayer

pt_PT and pt_BR are similar but have some differences. We definitely can make your suggestion, but it might not be 100% accurate. Let me know what you think. I can copy those words to pt_PT.

(If we would do that, why do we need them both and not expose one pt locale?)

We need both because for example the location or phone modules are substantially different for both.

Maybe could copy over and then we could make tweaks to the pt_PT version in future if there are any words which are uncommon in pt_PT.

You're right, good point. I'll do that.

Thank you for your contribution @DanielShvarts2004 🙏
I see that this was your first contribution to our project.
Would you mind answering some questions regarding your contribution? This way we can understand the potential struggles or confusions new contributors might have when getting into the project. If you don't want to answer, please ignore this comment:

1. What did motivate you to do your contribution?
2. Did you read our documentation regarding contributing before starting to work on your contribution?
3. How clear was the process of working on your contribution (before the PR) for you? Was there ever a time while working in the project where you didn't know what to do? If so how did you solve your problem?
4. How clear was the process of the code review (PR) for you? Was there ever a time you felt unsure about the current situation?
5. Anything else you'd like to share with the Faker team?

1. I've been wanting to contribute to an open source project for a while, and had some free time. We're using faker js in the company i work for and i like it, so I thought it could be nice to make a contribution here. Found this first issue and decided to go for it. Hope it will help someone in the future.

2. Yes

3. The project was clear.

4. The maintainers were responsive, helpful, very kind and nice. Thank youu!