Skip to content

feat(revert): add more arabic names dataset #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Shinigami92 merged 1 commit into from
Jan 30, 2022
Merged

feat(revert): add more arabic names dataset #365

Shinigami92 merged 1 commit into from
Jan 30, 2022

Conversation

@JessicaSachs
Copy link
Contributor

@JessicaSachs JessicaSachs commented Jan 30, 2022

Reverts #362

@JessicaSachs JessicaSachs requested a review from a team as a code owner January 30, 2022 05:59
@Shinigami92 Shinigami92 changed the title Revert "feat: add more arabic names dataset" feat(revert): add more arabic names dataset Jan 30, 2022
@Shinigami92 Shinigami92 requested review from a team and ST-DDT January 30, 2022 06:15
@ST-DDT
Copy link
Member

ST-DDT commented Jan 30, 2022

Does reverting this reduce our work?
If not, then we could just leave it in here as an accident.

@Shinigami92 Shinigami92 merged commit 6667ca7 into main Jan 30, 2022
@Shinigami92
Copy link
Member

Shinigami92 commented Jan 30, 2022

Does reverting this reduce our work?

If not, then we could just leave it in here as an accident.

Due to the CI fails and no other PR can be worked on / rebased, we will revert it for now
I talked already to the contributor and said that we are sorry. Everything is okay right now, we will do this in v6.2 as planned 👌

@ST-DDT ST-DDT deleted the revert-362-arabicDS branch January 30, 2022 09:47
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
@JessicaSachs @bmenant
Revert "feat: add more arabic names dataset (faker-js#362)" (faker-js…
c15850c 
…#365)
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@JessicaSachs @demipel8
Revert "feat: add more arabic names dataset (faker-js#362)" (faker-js…
2921500 
…#365)
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@JessicaSachs @demipel8
Revert "feat: add more arabic names dataset (faker-js#362)" (faker-js…
1d432d8 
…#365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis prisis approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ejcheng ejcheng ejcheng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JessicaSachs @ST-DDT @Shinigami92 @prisis @ejcheng