Skip to content

docs: fix lack of contrast in developer console log message in light mode #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xDivisionByZerox merged 1 commit into from
Dec 15, 2025
Merged

docs: fix lack of contrast in developer console log message in light mode #3673

xDivisionByZerox merged 1 commit into from
Dec 15, 2025

Conversation

@matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Dec 14, 2025 •
edited
Loading

fix #3672

light mode
Screenshot 2025-12-14 at 20 21 28

dark mode
Screenshot 2025-12-14 at 20 21 51

@matthewmayer matthewmayer requested a review from a team as a code owner December 14, 2025 13:12
@netlify
Copy link

netlify bot commented Dec 14, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a1ed241
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/693eb7afa7be510008e1f9b6
😎 Deploy Preview https://deploy-preview-3673.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Dec 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (1cf3991) to head (a1ed241).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3673   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2995     2995           
  Lines      236313   236313           
  Branches      941      940    -1     
=======================================
  Hits       236256   236256           
  Misses         57       57
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox added this to the v10.x milestone Dec 14, 2025
@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Dec 14, 2025
xDivisionByZerox
xDivisionByZerox approved these changes Dec 14, 2025
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work. Thank you 👍

@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Dec 15, 2025
Merged via the queue into faker-js:next with commit ec09440 Dec 15, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matthewmayer matthewmayer

Labels

c: docs Improvements or additions to documentation p: 1-normal Nothing urgent

Projects

None yet

Milestone

v10.x

Development

Successfully merging this pull request may close these issues.

Lack of contrast in developer console log message in light mode

3 participants

@matthewmayer @Shinigami92 @xDivisionByZerox