feat(finance): add IR iban #3677
Closed
+14,156
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…word also add country to location id_ID translation. (faker-js#3608)
… continents, countries and directions (hu) (faker-js#3618)
Co-authored-by: Matt Mayer <matt@matthewmayer.co.uk>
Co-authored-by: Matt Mayer <matt@matthewmayer.co.uk>
Co-authored-by: Matt Mayer <152770+matthewmayer@users.noreply.github.com> Co-authored-by: Matt Mayer <matt@matthewmayer.co.uk>
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
Co-authored-by: xDivisionByZerox <leyla.jaehnig@gmx.de>
Co-authored-by: Matt Mayer <152770+matthewmayer@users.noreply.github.com> Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
Co-authored-by: Matt Mayer <152770+matthewmayer@users.noreply.github.com> Co-authored-by: Matt Mayer <matt@matthewmayer.co.uk>
…cause of wrong IR iban validation)
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the finance > iban is missing IR locale
after i added the patterns, my test didn't pass because of validator.js isIBAN validation (it had wrong pattern)
validator.js was fixed in this PR and so the validator package in faker was also updated