Skip to content

chore: commit package-lock.json #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
damienwebdev merged 2 commits into from
Jan 9, 2022
Merged

chore: commit package-lock.json #39

damienwebdev merged 2 commits into from
Jan 9, 2022

Conversation

@Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jan 9, 2022

close #38

@Shinigami92 Shinigami92 self-assigned this Jan 9, 2022
@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 9, 2022
damienwebdev
damienwebdev approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I pulled the lockfile locally and diffed the trees here myself. Everything seems in order.

@damienwebdev damienwebdev merged commit f2c7228 into faker-js:main Jan 9, 2022
@Shinigami92 Shinigami92 deleted the Shinigami92/commit-package-lock-file branch January 9, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prisis prisis prisis approved these changes

@damienwebdev damienwebdev damienwebdev approved these changes

Assignees

@Shinigami92 Shinigami92

Labels

c: chore PR that doesn't affect the runtime behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Commit package lock file

3 participants

@Shinigami92 @prisis @damienwebdev