Skip to content

chore(deps): add prettier-plugin-organize-imports #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Shinigami92 merged 5 commits into from
Mar 1, 2022
Merged

chore(deps): add prettier-plugin-organize-imports #552

Shinigami92 merged 5 commits into from
Mar 1, 2022

Conversation

@Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Feb 23, 2022 •
edited
Loading

Add dev depenedency prettier-plugin-organize-imports

This will organize all imports with prettier

I will format all files when some other currently higher prio PRs are merged to reduce merge conflicts

@Shinigami92 Shinigami92 added the c: dependencies Pull requests that adds/updates a dependency label Feb 23, 2022
@Shinigami92 Shinigami92 self-assigned this Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022 •
edited
Loading

Codecov Report

Merging #552 (10b91e5) into main (0afdf03) will decrease coverage by 0.00%.
The diff coverage is 6.00%.

@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1920     1920              
  Lines      176368   176367       -1     
  Branches      904      904              
==========================================
- Hits       175211   175210       -1     
  Misses       1101     1101              
  Partials       56       56
Impacted Files Coverage Δ
src/internet.ts 100.00% <ø> (ø)
src/locale/en_AU.ts 0.00% <0.00%> (ø)
src/locale/en_AU_ocker.ts 0.00% <0.00%> (ø)
src/locale/en_BORK.ts 0.00% <0.00%> (ø)
src/locale/en_CA.ts 0.00% <0.00%> (ø)
src/locale/en_GB.ts 0.00% <0.00%> (ø)
src/locale/en_GH.ts 0.00% <0.00%> (ø)
src/locale/en_IE.ts 0.00% <0.00%> (ø)
src/locale/en_IND.ts 0.00% <0.00%> (ø)
src/locale/en_NG.ts 0.00% <0.00%> (ø)
... and 41 more

@Shinigami92 Shinigami92 added the needs rebase There is a merge conflict label Feb 24, 2022
@Shinigami92 Shinigami92 force-pushed the prettier-plugin-organize-imports branch from def5784 to b197741 Compare February 24, 2022 21:06
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Feb 24, 2022
@Shinigami92
Copy link
Member Author

Shinigami92 commented Feb 24, 2022

image

lel, ... I think codecov/patch is totally useless 🤣

Maybe we should just disable it
@ST-DDT any ideas?

@ST-DDT
Copy link
Member

ST-DDT commented Feb 24, 2022

The issue here is that the imports are considered code, but are never taken into consideration regarding usage.
IMO this is a bug in the code coverage engine that needs fixing. As for us, we could remove this until it is fixed upstream.
We just have to take this into consideration when looking at PRs that add features.

@Shinigami92
Copy link
Member Author

Shinigami92 commented Feb 24, 2022

@bcoe Do you know anything about this? Is this a bug of c8?

@Shinigami92 Shinigami92 marked this pull request as ready for review February 24, 2022 22:36
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 24, 2022 22:36
@ST-DDT ST-DDT requested a review from a team February 24, 2022 22:38
@bcoe
Copy link

bcoe commented Feb 26, 2022

@bcoe Do you know anything about this? Is this a bug of c8?

My hunch is that it might have to do with how imports are transpiled to JavaScript, vs., an issue with the coverage engine itself. What does the transpiled code look like?

@bcoe
Copy link

bcoe commented Feb 26, 2022

(if you can provide a minimal isolated example that's helpful).

@ejcheng ejcheng added the c: chore PR that doesn't affect the runtime behavior label Feb 27, 2022
@Shinigami92 Shinigami92 merged commit ced5f3d into main Mar 1, 2022
@Shinigami92 Shinigami92 deleted the prettier-plugin-organize-imports branch March 1, 2022 18:10
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
chore(deps): add prettier-plugin-organize-imports (faker-js#552)
f129d34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis prisis approved these changes

Assignees

@Shinigami92 Shinigami92

Labels

c: chore PR that doesn't affect the runtime behavior c: dependencies Pull requests that adds/updates a dependency

Projects

None yet

Milestone

v6.0 - Ensure Project Foundation

Development

Successfully merging this pull request may close these issues.

6 participants

@Shinigami92 @ST-DDT @bcoe @prisis @ejcheng