Drv 599 complete 3rd party auth support #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
parkhomenko
previously approved these changes
Apr 5, 2021
faunaee
suggested changes
Apr 5, 2021
Contributor
faunaee
left a comment
There was a problem hiding this comment.
I've made a few suggestions for edits to the README file.
Otherwise, looks good. The new functions included in this PR and the ones previously added for the V4 driver appear to work well.
faunaee
suggested changes
Apr 6, 2021
Contributor
faunaee
left a comment
There was a problem hiding this comment.
Looks pretty good, overall. I made one suggestion unrelated to your changes.
It would be great to add an example of using omitempty in the README file.
README.md
Outdated
Comment on lines
116
to
117
| For more information about FaunaDB query language, consult our query language | ||
| [reference documentation](https://docs.fauna.com/fauna/current/reference/queryapi/). |
Contributor
There was a problem hiding this comment.
Suggested change
| For more information about FaunaDB query language, consult our query language | |
| [reference documentation](https://docs.fauna.com/fauna/current/reference/queryapi/). | |
| For more information about Fauna Query Language (FQL), consult our query language | |
| [reference documentation](https://docs.fauna.com/fauna/current/api/fql/). |
faunaee
suggested changes
Apr 6, 2021
Contributor
faunaee
left a comment
There was a problem hiding this comment.
One last change, to fix the markup for the omitempty heading.
parkhomenko
reviewed
Apr 7, 2021
| go_version: "1.16.3" | ||
| version: nightly | ||
| steps: | ||
| - build_and_test |
parkhomenko
previously approved these changes
Apr 7, 2021
parkhomenko
approved these changes
Apr 7, 2021
artem-kurnikov
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following functions were added: