Add cropping functionality #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selected region is copied, pasted into the upper left corner, and then resized to the size of the selection. Added to the R key.
fchollet
requested changes
Feb 20, 2020
| setCellSymbol(cell, symbol); | ||
| } | ||
| } | ||
| $('#output_grid_size').val((xs[xs.length - 1] - minx + 1) + 'x' + (ys[ys.length - 1] - miny + 1)); |
Owner
There was a problem hiding this comment.
Rather than manipulating the HTML directly, you should fill in CURRENT_OUTPUT_GRID then sync via syncFromDataGridToEditionGrid().
fchollet
reviewed
Feb 20, 2020
| } | ||
| // Crop code | ||
| if (event.which == 82) { | ||
| // Press R |
Owner
There was a problem hiding this comment.
Ok, but this means the feature is not discoverable by a user other than you... the R key should be advertised (in the same place as the C and V commands)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected region is copied, pasted into the upper left corner, and then
resized to the size of the selection. Added to the R key.